Now starting from the bottom up...
the shoes should
- provide adequate arch support
- prevent silt from entering
- protect against coral
- defend against stingray spines
- ideally not have an obnoxious color (for fish)
In addition, sandals for casual time after fishing is a good idea.
Socks do help keep silt out if the shoes are good.